-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record all broadcast values in xtrigger return [backport] #3280
Record all broadcast values in xtrigger return [backport] #3280
Conversation
Two test chunks have failed on Travis CI, with the results:
All failure cases in CHUNK 2 are known flaky tests, as moved under the Update: under an since-edited state of the leading comment in #2894, it states that |
These are likely failing because of the host change in Travis. Don't spend too much time on them. |
Sure, I wont. I just wanted to justify the failures to reassure reviewers that this is okay to merge. If you are satisfied already, that is great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks @sadielbartholomew 👍
The chunk 1 failures definitely can't be related to this change, so merging... |
These changes close (for
7.8.x
) #3275.This PR is a direct equivalent to #3276, to backport it to
7.8.x
. For reviewing, note the only difference to the counterpart PR is thatxtriggers/01-suite_state.t
still sits undertests/
here, rather than underflakytests/
.CONTRIBUTING.md
and added my name as a Code Contributor.