Unit test batch sys handlers slurm and lsf #3358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewrmshin
force-pushed
the
unittest-batch_sys_handlers-slurm-and-lsf
branch
from
bd98b3f
to
94499c8
Compare
matthewrmshin
force-pushed
the
unittest-batch_sys_handlers-slurm-and-lsf
branch
from
94499c8
to
51fc690
Compare
Add unit tests for slurm and lsf batch system handlers logic. Reverse suite name and task ID in job name for consistency with PBS handler. * To look like `task.cycle.suite`. Remove redundant `.filter_poll_output` methods from handlers. Replace `.get_fail_signals` methods with `.FAIL_SIGNALS` constants.
matthewrmshin
force-pushed
the
unittest-batch_sys_handlers-slurm-and-lsf
branch
from
51fc690
to
f1d511f
Compare
kinow
approved these changes
Sep 12, 2019
kinow
reviewed
Sep 12, 2019
hjoliver
approved these changes
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests for slurm and lsf batch system handlers logic. More of #3356.
Reverse suite name and task ID in job name for consistency with PBS handler.
task.cycle.suite.Remove redundant
.filter_poll_outputmethods from handlers.Replace
.get_fail_signalsmethods with.FAIL_SIGNALSconstants.This is a small change with no associated Issue.
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.