Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests added covering moab.py and loadleveler.py #3411

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Tests added covering moab.py and loadleveler.py #3411

merged 1 commit into from
Oct 16, 2019

Conversation

datamel
Copy link
Contributor

@datamel datamel commented Oct 15, 2019

Increase test coverage for batch system handlers, moab and loadleveler.

These changes close #3372

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Does not need tests (why?). They are tests.
  • No change log entry required (why? e.g. invisible to users).
  • No documentation update required.

@datamel datamel self-assigned this Oct 15, 2019
@datamel datamel added this to the cylc-8.0a2 milestone Oct 15, 2019
@datamel datamel requested a review from kinow October 15, 2019 15:45
hjoliver
hjoliver approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @datamel 👍

@hjoliver hjoliver merged commit e1a8bcc into cylc:master Oct 16, 2019
@datamel datamel deleted the batch-handlers-tests branch September 20, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

@kinow kinow kinow approved these changes

Assignees

@datamel datamel

Labels
None yet
Projects
None yet
Milestone
cylc-8.0a2
Development

Successfully merging this pull request may close these issues.

Use CI to run tests for batch systems
3 participants
@datamel @kinow @hjoliver