-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jinja2 and pyzmq, as well as some test/dev dependencies #3493
Conversation
pyzmq
|
jinja2This version (2.11.0) still supports 2.7, but is the last one. They have released 2.11.1 too, but that version has a single bug for async templates (no idea what's that, but I guess we are not using it). The 2.11.0 includes several bug fixes, some new features, and also many changes that affect the behaviour of the the Jinja2 API - though it is not clear if the API changed (i.e. not sure if they removed parameters, renamed functions, or anything that would break API binary? backward compatibility). Some interesting changes:
https://jinja.palletsprojects.com/en/2.11.x/changelog/#version-2-11-0 |
@@ -46,19 +46,19 @@ def find_version(*file_paths): | |||
'colorama==0.4.*', | |||
'graphene>=2.1,<3', | |||
'metomi-isodatetime==1!2.0.*', | |||
'jinja2>=2.10.1, <2.11.0', | |||
'jinja2==2.11.*', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, this could be
jinja2>=2.10.1, <2.12.0
(so users could still use 2.10.1 if they prefer?)jinja2~=2.11.1
(gives users 2.11.0, or anything after that)
Build passed. Marking as ready for review. Will add another commit with the change log (which means a new build in Travis, but the previous one can be seen here) |
e0b141d
to
1b8c323
Compare
@cylc/core - Jinja2 update - Watch out for any unexpected behaviour changes in workflows. |
I guess from the Cylc perspective, we support use of Jinja2 in workflow definitions, but it is not up to us to guarantee back-compatibility across Jinja2 releases. Best we can do is warn to watch out! |
These changes partially address #2572
Updates
jinja2
requirement to 2.11.0 or greater, which effectively means 2.11.1 today, andpyzmq
to 18.1.*, which means 18.1.0 today.Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.