Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suite-state point format conversion fix #3602

Merged
merged 3 commits into from
May 11, 2020

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented May 11, 2020

These changes close #3600:

Write cycle point format to the DB suite_params table if a format exists, even (in the ISO8601 case) if it is the default format. This allows cycle point conversion to work in the cylc suite-state command and the suite_state xtrigger function, if the upstream suite uses the default format but the downstream suite or command does not. (On master, we assumed that conversion is only necessary if the target suite uses a non-default format).

(Note I tried to write a unit test for this using CylcWorkflowTestCase in cylc/flow/tests/util.py but gave up when mocked objects got in the way of writing to the suite DB. The functional test is simple and easy to understand, at least).

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Appropriate tests are included (unit and/or functional).
  • Appropriate change log entry included.
  • No documentation update required (fix to behave as advertised).

@hjoliver hjoliver added the bug Something is wrong :( label May 11, 2020
@hjoliver hjoliver self-assigned this May 11, 2020
@hjoliver hjoliver added this to the cylc-8.0.0 milestone May 11, 2020
@hjoliver hjoliver mentioned this pull request May 11, 2020
6 tasks
@oliver-sanders oliver-sanders merged commit a326d90 into cylc:master May 11, 2020
@hjoliver hjoliver deleted the cycle-point-format branch May 11, 2020 22:55
@dpmatthews dpmatthews modified the milestones: cylc-8.0.0, cylc-8.0a2 May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suite_state cycle point format not converted for default case
4 participants