-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sequence bounds check for parent tasks. #3756
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proof the fix works:
|
hjoliver
force-pushed
the
sod-bugfix-tt
branch
from
August 19, 2020 11:30
fbc1f2d
to
3e6de0a
Compare
(rebased) |
Minimal functional test added (fails on master, passes here). |
oliver-sanders
approved these changes
Aug 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, tested with the following:
[scheduling]
initial cycle point = 1
final cycle point = 9
cycling mode = integer
[[graph]]
R3//P1 = a => b
P1 = b
6/P1 = b => c
MetRonnie
approved these changes
Aug 19, 2020
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses a bug (and untested functionality, evidently) found by @TomekTrzeciak in #3740 (comment)
In the following example,
bar
should trigger off offoo
in the first 3 cycles, then subsequentbar
's should trigger automatically (no parents):On this branch it works, but on master the scheduler shuts down finished after cycle point 3.
Since spawn-on-demand we auto-spawn parent-less tasks when their previous instance leaves the runahead pool (they have no parents to spawn them "on demand"). In this example,
bar.3
has a parent (foo.3
) butbar.4
has no parents and so has to be auto-spawned. To do this, whenbar.3
leaves the runahead pool we look at the next cycle point forbar
and see if it has parents there by looking for parents in each of its sequences. This parent-lookup gave the wrong result becausesequence.is_on_sequence(point)
disregards sequence bounds. The fix is to usesequence.is_valid(point)
(which correctly says thatbar.4
has no parents).Marking as Draft until I add a test.
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.