Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate task messages #3788

Merged
merged 7 commits into from
Aug 28, 2020
Merged

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Aug 25, 2020

Update: see #3820 for follow on.

These changes close #3428

Task messages, e.g. in

[runtime]
    [[my_task]]
        [[[outputs]]]
            foo = I am an invalid task message: the colon is to blame

can only have colons in them if the first part of the message is a logging severity level plus colon, e.g. INFO:, because everything before the first colon is treated as a severity level.

This PR causes validation to fail if colons are misused.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Appropriate tests are included (unit).
  • Appropriate change log entry included.
  • No dependency changes.

@MetRonnie MetRonnie added bug Something is wrong :( small labels Aug 25, 2020
@MetRonnie MetRonnie added this to the cylc-8.0a3 milestone Aug 25, 2020
@MetRonnie MetRonnie self-assigned this Aug 25, 2020
cylc/flow/unicode_rules.py Outdated Show resolved Hide resolved
cylc/flow/__init__.py Show resolved Hide resolved
cylc/flow/unicode_rules.py Outdated Show resolved Hide resolved
cylc/flow/unicode_rules.py Outdated Show resolved Hide resolved
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested as working.

@hjoliver hjoliver merged commit 4317fe6 into cylc:master Aug 28, 2020
@MetRonnie MetRonnie deleted the validate-msg-triggers branch August 28, 2020 09:06
@hjoliver hjoliver modified the milestones: cylc-8.0a3, cylc-8.0b0 Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :( small superseded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cylc Validate check custom task outputs
3 participants