-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate task messages #3788
Merged
Merged
Validate task messages #3788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetRonnie
commented
Aug 25, 2020
MetRonnie
force-pushed
the
validate-msg-triggers
branch
from
August 26, 2020 18:22
a753537
to
cfeb302
Compare
MetRonnie
commented
Aug 26, 2020
MetRonnie
force-pushed
the
validate-msg-triggers
branch
from
August 27, 2020 09:28
cfeb302
to
6480355
Compare
oliver-sanders
approved these changes
Aug 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, tested as working.
hjoliver
approved these changes
Aug 28, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: see #3820 for follow on.
These changes close #3428
Task messages, e.g. in
can only have colons in them if the first part of the message is a logging severity level plus colon, e.g.
INFO:
, because everything before the first colon is treated as a severity level.This PR causes validation to fail if colons are misused.
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.