Update protobuf and pyzmq

[kinow]

This is a small change with no associated Issue.

Requirements check-list

• I have read CONTRIBUTING.md and added my name as a Code Contributor.
• Contains logically grouped changes (else tidy your branch by rebase).
• Does not contain off-topic changes (use other PRs for other changes).
• Already covered by existing tests.
• Appropriate change log entry included.
• No documentation update required.
• Created an issue at cylc-flow conda-forge repository with version changes (if you changed dependencies in setup.py, see recipe/meta.yaml). - Update pyzmq conda-forge/cylc-flow-feedstock#13

[kinow]

Changes in protobuf 3.13

    JSON format conformance fixes:
        Reject lowercase t for Timestamp json format.
        Print full_name directly for extensions (no camelCase).
        Reject boolean values for integer fields.
        Reject NaN, Infinity, -Infinity that is not quoted.
        Base64 fixes for bytes fields: accept URL-safe base64 and missing padding.
    Bugfix for fields/files named "async" or "await".
    Improved the error message when AttributeError is returned from getattr
    in EnumTypeWrapper.

And in pyzmq 19:

    Cython backend: Build Cython extensions with language level “3str” (requires Cython 0.29)
    Cython backend: You can now cimport zmq
    Asyncio: Fix memory leak in Poller
    Log: Much improved logging in zmq.log (see Asynchronous Logging via PyZMQ)
    Log: add python -m zmq.log entrypoint
    Sources generated with Cython 0.29.15

[kinow]

Re-compiled the .proto file, but looks like it only added a new comment 😆

protoc --experimental_allow_proto3_optional -I=./ --python_out=./ data_messages.proto
git diff
diff --git a/cylc/flow/data_messages_pb2.py b/cylc/flow/data_messages_pb2.py
index a6160f8fc..8f99c465c 100644
--- a/cylc/flow/data_messages_pb2.py
+++ b/cylc/flow/data_messages_pb2.py
@@ -1,7 +1,7 @@
 # -*- coding: utf-8 -*-
 # Generated by the protocol buffer compiler.  DO NOT EDIT!
 # source: data_messages.proto
-
+"""Generated protocol buffer code."""
 from google.protobuf import descriptor as _descriptor
 from google.protobuf import message as _message
 from google.protobuf import reflection as _reflection

Version

protoc --version
libprotoc 3.13.0

[kinow]

If CI passes, and reviewers approve, I'll create the PR in cylc-flow-feedstock 👍

[dwsutherland]

looks like it only added a new comment 😆

Well done! will check soon... But tests passing so meh

[dwsutherland]

@kinow - I think I'm a little wary about not having a fixed protobuf version, as we'd have to trust they don't put breaking changes between subversions.. And people use the latest sub-version binary when generating the module..

We'll see how it goes.. 👍

[kinow]

@kinow - I think I'm a little wary about not having a fixed protobuf version, as we'd have to trust they don't put breaking changes between subversions.. And people use the latest sub-version binary when generating the module..

We'll see how it goes.. +1

Ah, I realized just now that I used a version range instead of the latest version pinned. It will be a good experiment to see if anything happens with their patch updates, but hopefully that should work 🤞

Creating the sibling PR for Conda. Thanks @dwsutherland !

[dwsutherland]

Ah, I realized just now that I used a version range instead of the latest version pinned. It will be a good experiment to see if anything happens with their patch updates, but hopefully that should work 🤞

Given that there release page is still at 3.13.0 .. It'll likely be fine..
https://github.com/protocolbuffers/protobuf/releases