Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove author_email from our Python packaging metadata #3879

Merged
merged 2 commits into from
Oct 19, 2020

Conversation

kinow
Copy link
Member

@kinow kinow commented Oct 19, 2020

These changes close #3713

author_email is one of the keys available for pip's packaging metadata. But it is not mandatory (see https://github.com/pypa/pip/blob/50aca38eafde71ac0314d14246f7ebf043695f5e/src/pip/_vendor/distlib/metadata.py#L620 for the mandatory ones—couldn't find in their docs, had to locate in the code 😢 )

The author_email requires a valid RFC-822 address. Since we are not using Google Groups, and Discourse does not offer an e-mail address, I think the best option is to simply remove it.

If users want to get in contact, they will need to visit our project URL (which is in the packaging metadata) and find how to reach us.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Does not need tests (why? packaging only).
  • Appropriate change log entry included.
  • No documentation update required.
  • No dependency changes. (checked the conda recipe, no mention of google groups 👍 )

@kinow
Copy link
Member Author

kinow commented Oct 19, 2020

One review should be enough. Don't think CI result matters 👍

Logged this issue during the previous release when I found the Google Groups e-mail. So better to fix now before we need to release the next alpha/beta version.

@kinow kinow self-assigned this Oct 19, 2020
@kinow kinow added this to the cylc-8.0a3 milestone Oct 19, 2020
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @kinow

@hjoliver hjoliver merged commit b74c58f into cylc:master Oct 19, 2020
@kinow kinow deleted the remove-googlegroups-email branch October 19, 2020 23:10
@hjoliver hjoliver modified the milestones: cylc-8.0a3, cylc-8.0b0 Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix cylc-flow setup.cfg metadata e-mail
2 participants