Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rsync to subprocpool #3953

Merged
merged 11 commits into from
Dec 10, 2020
Merged

Rsync to subprocpool #3953

merged 11 commits into from
Dec 10, 2020

Conversation

datamel
Copy link
Contributor

@datamel datamel commented Nov 19, 2020 •
edited
Loading

Moves rsync to the subprocpool.

These changes close Rsync to subprocpool #3840.

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Already covered by existing tests.
  • No change log entry required (invisible to users).
  • No documentation update required.
  • No dependency changes.

@datamel datamel added the efficiency For notable efficiency improvements label Nov 19, 2020
@datamel datamel added this to the cylc-8.0a4 milestone Nov 19, 2020
@datamel datamel self-assigned this Nov 19, 2020
@datamel datamel marked this pull request as draft November 19, 2020 14:41
oliver-sanders
oliver-sanders reviewed Nov 23, 2020
View reviewed changes
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the right approach 👍.

cylc/flow/task_job_mgr.py Outdated Show resolved Hide resolved
cylc/flow/task_remote_mgr.py Show resolved Hide resolved
@datamel datamel marked this pull request as ready for review November 24, 2020 19:30
@MetRonnie
Copy link
Member

Still waiting for a couple of Oliver's suggestions to be implemented I think?

@oliver-sanders
Copy link
Member

Ah, nothing important.

Please do a rebase squash before merging though.

@oliver-sanders
Copy link
Member

tests/f/remote/04-symlink-dirs.t is unhappy

@datamel
Copy link
Contributor Author

datamel commented Dec 10, 2020

tests/f/remote/04-symlink-dirs.t is unhappy

Just looking into it now, hopefully I'll get to the bottom of it quickly!

@oliver-sanders oliver-sanders merged commit d4ded5b into cylc:master Dec 10, 2020
@hjoliver hjoliver mentioned this pull request Dec 13, 2020
Closed
@oliver-sanders oliver-sanders modified the milestones: cylc-8.0a4, cylc-8.0a3 Dec 14, 2020
@oliver-sanders oliver-sanders mentioned this pull request Dec 23, 2020
Closed
@hjoliver hjoliver modified the milestones: cylc-8.0a3, cylc-8.0b0 Feb 25, 2021
@oliver-sanders oliver-sanders removed the efficiency For notable efficiency improvements label Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders oliver-sanders approved these changes

@MetRonnie MetRonnie MetRonnie approved these changes

Assignees

@datamel datamel

Labels
None yet
Projects
None yet
Milestone
cylc-8.0b0
Development

Successfully merging this pull request may close these issues.
4 participants
@datamel @MetRonnie @oliver-sanders @hjoliver