Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move suite servers to scheduler section of global config #3962

Merged
merged 7 commits into from
Nov 26, 2020
Merged

move suite servers to scheduler section of global config #3962

merged 7 commits into from
Nov 26, 2020

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Nov 25, 2020 •
edited
Loading

These changes partially address #3696

They are last changes earmarked for the global config 🎉

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Does not need tests: just a renaming.
  • No change log entry required (why? e.g. invisible to users).
  • No documentation update required: Documentation to be dealt with at the end of conf: ensure all proposed changes have been enacted #3696

@wxtim wxtim self-assigned this Nov 25, 2020
@wxtim wxtim added this to the cylc-8.0.0 milestone Nov 25, 2020
@wxtim wxtim force-pushed the conf.move-suite-server-items-to-scheduler branch from 71d9104 to e693cbb Compare November 25, 2020 13:28
@wxtim wxtim mentioned this pull request Nov 25, 2020
Closed
kinow
kinow approved these changes Nov 26, 2020
View reviewed changes
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found nothing out of ordinary. @MetRonnie 's comment looks correct, in that the global config structure is missing a level with run hosts?

cylc/flow/cfgspec/globalcfg.py Show resolved Hide resolved
MetRonnie
MetRonnie requested changes Nov 26, 2020
View reviewed changes
cylc/flow/cfgspec/globalcfg.py Outdated Show resolved Hide resolved
cylc/flow/cfgspec/globalcfg.py Outdated Show resolved Hide resolved
cylc/flow/cfgspec/globalcfg.py Outdated Show resolved Hide resolved
wxtim and others added 4 commits November 26, 2020 10:44
@wxtim
moved suite host self-identification to schediler section
b4063e2
@wxtim @MetRonnie
Update cylc/flow/cfgspec/globalcfg.py
24fd840 
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
@wxtim @MetRonnie
Update cylc/flow/cfgspec/globalcfg.py
1aa283c 
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
@wxtim
moved auto restart delay
bdeac72
@wxtim wxtim force-pushed the conf.move-suite-server-items-to-scheduler branch from c22cb4e to bdeac72 Compare November 26, 2020 12:11
@MetRonnie
Copy link
Member

I'll leave it you Tim whether you want to merge or squash/rebase

@wxtim wxtim merged commit 5298af7 into cylc:master Nov 26, 2020
@MetRonnie MetRonnie modified the milestones: cylc-8.0.0, cylc-8.0a3 Nov 26, 2020
@MetRonnie MetRonnie added the config change Involves a change to global or workflow config label Dec 1, 2020
@hjoliver hjoliver modified the milestones: cylc-8.0a3, cylc-8.0b0 Feb 25, 2021
@wxtim wxtim deleted the conf.move-suite-server-items-to-scheduler branch March 22, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MetRonnie MetRonnie MetRonnie approved these changes

@kinow kinow kinow approved these changes

Assignees

@wxtim wxtim

Labels
config change Involves a change to global or workflow config
Projects
None yet
Milestone
cylc-8.0b0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxtim @MetRonnie @kinow @hjoliver