remove 'extra log files' from config

cylc/flow/cfgspec/suite.py

@@ -778,17 +778,7 @@
                 * :cylc:conf:`[..]exit-script`
 
             ''')
-            Conf('extra log files', VDR.V_STRING_LIST, desc='''
-                A list of user-defined log files associated with a task. Log
-                files must reside in the job log directory
-                ``$CYLC_TASK_LOG_DIR`` and ideally should be named using the
-                ``$CYLC_TASK_LOG_ROOT`` prefix (see :ref:`Task Job Script
-                Variables`).
 
-                Example:
-
-                   ``job.custom-log-name``
-            ''')
             Conf('work sub-directory', VDR.V_STRING, desc='''
                 Task job scripts are executed from within *work directories*
                 created automatically under the suite run directory. A task
@@ -1324,8 +1314,9 @@ def upg(cfg, descr):
     u.obsolete(
         '8.0.0',
         ['cylc', 'health check interval'])
-    u.obsolete('8.0.0', ['runtime', '__MANY__', 'job', 'shell'])
     u.obsolete('8.0.0', ['runtime', '__MANY__', 'events', 'mail retry delays'])
+    u.obsolete('8.0.0', ['runtime', '__MANY__', 'extra log files'])
+    u.obsolete('8.0.0', ['runtime', '__MANY__', 'job', 'shell'])
     u.obsolete('8.0.0', ['cylc', 'abort if any task fails'])
     u.obsolete('8.0.0', ['cylc', 'events', 'abort if any task fails'])
     u.obsolete('8.0.0', ['cylc', 'events', 'mail retry delays'])

cylc/flow/job_pool.py

@@ -21,7 +21,6 @@
 """
 from copy import deepcopy
 import json
-import os
 from time import time
 
 from cylc.flow import LOG, ID_DELIM
@@ -159,10 +158,6 @@ def insert_db_job(self, row_idx, row):
                 poverride(rtconfig, overrides, prepend=True)
             else:
                 rtconfig = tdef.rtconfig
-            j_buf.extra_logs.extend(
-                [os.path.expanduser(os.path.expandvars(log_file))
-                 for log_file in rtconfig['extra log files']]
-            )
         except SuiteConfigError:
             LOG.exception((
                 'ignoring job %s from the suite run database\n'

cylc/flow/scripts/cat_log.py

@@ -34,10 +34,6 @@
 '[JOB-HOST]retrieve job logs = True') and the job is not currently running, the
 local (retrieved) log will be accessed unless '-o/--force-remote' is used.
 
-Custom job logs (written to $CYLC_TASK_LOG_DIR on the job host) can be
-listed in 'extra log files' in the suite definition. The file
-name must be given, but can be discovered with '--mode=l' (list-dir).
-
 The correct cycle point format of the suite must be used for task job logs,
 but can be discovered with '--mode=d' (print-dir).
 

cylc/flow/task_job_mgr.py

@@ -943,9 +943,6 @@ def _prep_submit_task_job_impl(self, suite, itask, rtconfig):
             itask.submit_num] = itask.platform['name']
 
         itask.summary['batch_sys_name'] = itask.platform['batch system']
-        for name in rtconfig['extra log files']:
-            itask.summary['logfiles'].append(
-                os.path.expanduser(os.path.expandvars(name)))
         try:
             batch_sys_conf = self.task_events_mgr.get_host_conf(
                 itask, 'batch systems')[itask.summary['batch_sys_name']]

tests/flakyfunctional/events/01-task/flow.cylc

@@ -24,8 +24,6 @@
         """
 [runtime]
     [[root]]
-        # make the event handler log available to gcylc:
-        extra log files = {{ EVNTLOG }}
         script = "true" # fast
 
     [[prep]]

tests/functional/cylc-get-config/00-simple/section2.stdout

@@ -8,7 +8,6 @@
     pre-script = 
     script = 
     post-script = 
-    extra log files = 
     work sub-directory = 
     [[[meta]]]
         title = 
@@ -86,7 +85,6 @@
     exit-script = 
     pre-script = 
     post-script = 
-    extra log files = 
     work sub-directory = 
     [[[meta]]]
         title = 
@@ -164,7 +162,6 @@
     exit-script = 
     pre-script = 
     post-script = 
-    extra log files = 
     work sub-directory = 
     [[[meta]]]
         title = 
@@ -242,7 +239,6 @@
     pre-script = 
     script = 
     post-script = 
-    extra log files = 
     work sub-directory = 
     [[[directives]]]
         job_type = serial
@@ -321,7 +317,6 @@
     pre-script = 
     script = 
     post-script = 
-    extra log files = 
     work sub-directory = 
     [[[directives]]]
         job_type = parallel
@@ -400,7 +395,6 @@
     exit-script = 
     pre-script = 
     post-script = 
-    extra log files = 
     work sub-directory = 
     [[[directives]]]
         job_type = serial
@@ -479,7 +473,6 @@
     exit-script = 
     pre-script = 
     post-script = 
-    extra log files = 
     work sub-directory = 
     [[[directives]]]
         job_type = serial
@@ -558,7 +551,6 @@
     exit-script = 
     pre-script = 
     post-script = 
-    extra log files = 
     work sub-directory = 
     [[[directives]]]
         job_type = parallel
@@ -637,7 +629,6 @@
     exit-script = 
     pre-script = 
     post-script = 
-    extra log files = 
     work sub-directory = 
     [[[directives]]]
         job_type = parallel
@@ -716,7 +707,6 @@
     exit-script = 
     pre-script = 
     post-script = 
-    extra log files = 
     work sub-directory = 
     [[[directives]]]
         job_type = serial
@@ -795,7 +785,6 @@
     exit-script = 
     pre-script = 
     post-script = 
-    extra log files = 
     work sub-directory = 
     [[[directives]]]
         job_type = serial
@@ -874,7 +863,6 @@
     exit-script = 
     pre-script = 
     post-script = 
-    extra log files = 
     work sub-directory = 
     [[[directives]]]
         job_type = parallel
@@ -953,7 +941,6 @@
     exit-script = 
     pre-script = 
     post-script = 
-    extra log files = 
     work sub-directory = 
     [[[directives]]]
         job_type = parallel

tests/functional/deprecations/01-cylc8-basic/flow.cylc

@@ -33,6 +33,7 @@
 
 [runtime]
     [[foo, cat, dog]]
+        extra log files =
         [[[job]]]
             shell = fish
         [[[events]]]

tests/functional/deprecations/01-cylc8-basic/validation.stderr

@@ -3,8 +3,9 @@ WARNING -  * (8.0.0) [cylc][force run mode] - DELETED (OBSOLETE)
 WARNING -  * (8.0.0) [cylc][authentication] - DELETED (OBSOLETE)
 WARNING -  * (8.0.0) [cylc][log resolved dependencies] - DELETED (OBSOLETE)
 WARNING -  * (8.0.0) [cylc][required run mode] - DELETED (OBSOLETE)
-WARNING -  * (8.0.0) [runtime][foo, cat, dog][job][shell] - DELETED (OBSOLETE)
 WARNING -  * (8.0.0) [runtime][foo, cat, dog][events][mail retry delays] - DELETED (OBSOLETE)
+WARNING -  * (8.0.0) [runtime][foo, cat, dog][extra log files] - DELETED (OBSOLETE)
+WARNING -  * (8.0.0) [runtime][foo, cat, dog][job][shell] - DELETED (OBSOLETE)
 WARNING -  * (8.0.0) [cylc][abort if any task fails] - DELETED (OBSOLETE)
 WARNING -  * (8.0.0) [cylc][disable automatic shutdown] - DELETED (OBSOLETE)
 WARNING -  * (8.0.0) [cylc][reference test] - DELETED (OBSOLETE)

tests/functional/graphql/02-root-queries/flow.cylc

@@ -96,7 +96,6 @@ baa => qaz
             trigger1 = "data ready"
 
     [[baa]]
-        extra log files = $HOME/startrek/captains.log
         [[[meta]]]
             description = "some task baa"
         [[[environment]]]