Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templatevars: parse CLI opts with literal_eval #3974

Merged
merged 4 commits into from
Dec 7, 2020

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Dec 1, 2020

Apologies, oversight on my part, it turned out to be a three line change rather than the two lines predicted.

For this PR I have upgraded the set-file logic along with the CLI option (hence the unexpected third line), can revert though it would be somewhat inconsistent. If it is a problem then we could potentially use a different CLI opt for specifying type variables.

Rationale (discussed at meeting)

  • We would expect the -s, --set option to be used interactively so the change shouldn't impact user scripts.
  • And if it does the CLI has changed anyway.
  • Set-files may be more controversial, however, I don't think these are very widely used.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Appropriate tests are included (unit and/or functional).
  • Appropriate change log entry included.
  • (master branch) I have opened a documentation PR at cylc/cylc-doc/pull/XXXX.
  • No dependency changes.

@oliver-sanders oliver-sanders added this to the cylc-8.0a3 milestone Dec 1, 2020
@oliver-sanders oliver-sanders self-assigned this Dec 1, 2020
@hjoliver
Copy link
Member

hjoliver commented Dec 1, 2020

Hahaha 🤣 Quickest PR ever.

Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested as working 👍

@wxtim wxtim merged commit a6bac41 into cylc:master Dec 7, 2020
@oliver-sanders oliver-sanders deleted the literal_eval branch December 7, 2020 10:41
@hjoliver hjoliver modified the milestones: cylc-8.0a3, cylc-8.0b0 Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants