-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix trailing slash in reg (workflow name) bug #4011
Conversation
Did you get to the bottom of why the exact argument specified to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is harmless and should work for both REG/path uses, ..
in paths now get expanded.
Not so worried about testing as the universal identifier work will centralise this.
I assumed it's something to do with how mutations are handled, seeing as removing the slash before the |
I'm not sure this is the right solution. If the registered suite name is "foo", then "foo/" is not the correct name, so If that's confusing because it's easier to accidentally register |
The trouble with that is tab autocompletion adds a trailing slash to the directory name, so it would be an inconvenience to have to remove it every time. |
OK fair point. Approving on the basis that suite name often mirrors source dir name |
These changes close #4010
It seems that passing a reg with a trailing slash to the
mutations_kwargs
dict was the reason for this bug. As such I've fixed it everywhere I found amutations_kwargs
dict.Does this need a functional test?
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.