validate: do not check for circular/cyclic graph if size is above limit #4020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limit is on number of tasks. Provide an option "--check-circular" to always perform this check. It also is always done when "--strict" is used.
MetRonnie
force-pushed
the
cyclic-validation
branch
from
702470e
to
f736dfb
Compare
oliver-sanders
approved these changes
Jan 4, 2021
|
MetRonnie
commented
Jan 5, 2021
cylc/flow/scripts/validate.py
Outdated
Comment on lines
57
to
62
| parser.add_option( | ||
| "--check-circular", | ||
| help="Check for circular dependencies in graphs when the number of " | ||
| "tasks is greater than 100. This can be slow when the number of " | ||
| "tasks is high.", | ||
| action="store_true", default=False, dest="check_circular") |
There was a problem hiding this comment.
Could also add the abbreviation --cc if that's worth doing?
hjoliver
reviewed
Jan 10, 2021
hjoliver
reviewed
Jan 10, 2021
hjoliver
approved these changes
Jan 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes close #3869
This PR (last one of 2020!) introduces an option
--check-circulartocylc validate. If the number of tasks is less than the limit (100), checking for circular graph will always happen. If the number is above the limit, the check will be skipped (with a warning) unless--check-circularis used.Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.