Tui: warn about large flows

cylc/flow/scripts/tui.py

@@ -18,8 +18,15 @@
 
 View and control running suites in the terminal.
 
-(TUI = Terminal User Interface)
+(Tui = Terminal User Interface)
+
+WARNING: Tui is experimental and may break with large flows.
+An upcoming change to the way Tui receives data from the scheduler will make it
+much more efficient in the future.
 """
+# TODO: remove this warning once Tui is delta-driven
+# https://github.com/cylc/cylc-flow/issues/3527
+
 from textwrap import indent
 
 from urwid import html_fragment

cylc/flow/tui/app.py

@@ -322,7 +322,7 @@ def get_snapshot(self):
             })
         except (ClientError, ClientTimeout) as exc:
             # catch network / client errors
-            self.set_header(('suite_error', str(exc)))
+            self.set_header([('suite_error', str(exc))])
             return False
 
         if isinstance(data, list):
@@ -331,7 +331,7 @@ def get_snapshot(self):
                 message = data[0]['error']['message']
             except (IndexError, KeyError):
                 message = str(data)
-            self.set_header(('suite_error', message))
+            self.set_header([('suite_error', message)])
             return False
 
         if len(data['workflows']) != 1:
@@ -353,7 +353,7 @@ def get_node_id(node):
         """
         return node.get_value()['id_']
 
-    def set_header(self, message):
+    def set_header(self, message: list):
         """Set the header message for this widget.
 
         Arguments:
@@ -363,12 +363,18 @@ def set_header(self, message):
 
         """
         # put in a one line gap
-        if isinstance(message, list):
-            message.append('\n')
-        elif isinstance(message, tuple):
-            message = (message[0], message[1] + '\n')
-        else:
-            message += '\n'
+        message.append('\n')
+
+        # TODO: remove once Tui is delta-driven
+        # https://github.com/cylc/cylc-flow/issues/3527
+        message.extend([
+            (
+                'suite_error',
+                'TUI is experimental and may break with large flows'
+            ),
+            '\n'
+        ])
+
         self.view.header = urwid.Text(message)
 
     def _update(self, *_):

etc/bin/shellchecker

@@ -76,6 +76,7 @@ default () {
     # run a strict check on all "functional" scripts
     main '.' \
         --exclude 'etc/bin/live-graph-movie.sh' \
+        --exclude '.git' \
         -- -e SC1090
 }