-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete visualization section. #4273
Conversation
2a64d0d
to
3a2c8f0
Compare
Draft while I fix tests that use visualization settings to define the graph extent. |
67fdfcd
to
f5bbbbf
Compare
f5bbbbf
to
71c249c
Compare
@oliver-sanders maybe one review will do as this is mostly functional test tweaks. Assign another reviewer if you like though. |
Very likely that this closes #3696 - after this has gone in that will need a final check, and can then be closed... 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- read it
- tried it on random local workflows.
Moved the milestone forward on #3696 |
This is a
smallchangewith no associated Issue. Partially addresses #3379. May c-l-o-s-e #3696 (final check needed, of that umbrella issue).[visualization]
config section.get_graph_raw()
which was keeping track of family collapse state for the old UI. It now has a single argument to specify which families to collapse, and does not remember the collapsed statecylc graph
andcylc list
, and functional tests that use them, accordingly (slightly enhanced too: they can take an interval for the stop point).The PR would have been a lot smaller if I'd retained
[visualization]initial/final cycle point
which was being used by most of the functional tests that usecylc graph --reference
... but, better to remove the whole[visualization]
section now.flow.cylc
should define the whole graph, andcylc graph
etc. should just specify what part of it they want to see.Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.setup.py
andconda-environment.yml
. [None][vis]
tests)