Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log failure where attempting to use Cylc 8 on installed Cylc 7 workflow. #4312

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Log failure where attempting to use Cylc 8 on installed Cylc 7 workflow. #4312

merged 1 commit into from
Jul 21, 2021

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Jul 21, 2021 •
edited
Loading

These changes partially address #4309

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Appropriate tests are included (unit and/or functional).
  • No change log entry required (Beta bug we hope should be invisible to users).
  • No documentation update required.

@wxtim wxtim marked this pull request as draft July 21, 2021 07:55
@wxtim wxtim requested review from oliver-sanders and datamel July 21, 2021 09:25
@wxtim wxtim marked this pull request as ready for review July 21, 2021 09:25
@wxtim wxtim self-assigned this Jul 21, 2021
@wxtim wxtim added could be better Not exactly a bug, but not ideal. small labels Jul 21, 2021
@wxtim wxtim added this to the cylc-8.0.0 milestone Jul 21, 2021
@wxtim wxtim requested a review from oliver-sanders July 21, 2021 09:56
datamel
datamel approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@datamel datamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could update docstring of get_location for completeness, otherwise happy with the change.
Thanks @wxtim.

@wxtim wxtim force-pushed the small-issue.cylc8vscylc7 branch from 0f51544 to 1008c28 Compare July 21, 2021 14:13
@oliver-sanders oliver-sanders merged commit 9351122 into cylc:master Jul 21, 2021
@oliver-sanders oliver-sanders modified the milestones: cylc-8.0.0, cylc-8.0b2 Jul 27, 2021
@wxtim wxtim deleted the small-issue.cylc8vscylc7 branch March 22, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamel datamel datamel approved these changes

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@wxtim wxtim

Labels
could be better Not exactly a bug, but not ideal. small
Projects
None yet
Milestone
cylc-8.0b2
Development

Successfully merging this pull request may close these issues.
3 participants
@wxtim @oliver-sanders @datamel