Suicide takes precedence in otherwise identical triggers. #4334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjoliver
commented
Jul 30, 2021
Comment on lines
-219
to
-220
| if dep.suicide: | ||
| continue |
There was a problem hiding this comment.
This was preventing the upstream parent of a suicide trigger being recognized as a parent (matters for spawning if the suicided task has no other parents).
hjoliver
commented
Jul 30, 2021
Comment on lines
-1519
to
-1521
| elif suicide and name == right: | ||
| # "foo => !bar" should not create taskdef bar | ||
| pass |
There was a problem hiding this comment.
Comment incorrect. We still need to know the valid sequences of a suicided task, in case it isn't spawned by any non-suicide triggers (as is the case in the example that triggers the bug).
|
Invalid! 😜 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes close #4333
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.setup.pyandconda-environment.yml. (None)I'm not sure how to test this, as the bug is not deterministic.
Appropriate change log entry included.
No change log entry required (why? e.g. invisible to users).
No documentation update required. (now conforms to advertised behavior)