Source symlink fix #4338
Source symlink fix #4338
Conversation
cylc/flow/workflow_files.py
Outdated
| raise WorkflowFilesError( | ||
| 'Workflow run directory contains a broken source symlink: ' | ||
| f'{source_link}\n' | ||
| f'Restore the original source or modify this' | ||
| ' symlink, then try cylc install again.' | ||
| ) |
There was a problem hiding this comment.
I feel like the fact that the symlink is broken shouldn't be the main point, it's that Workflow source dir is not accessible (from the other error message). In fact, I think the other error message can be reused for this?
It makes me wonder if we should have a cli option for cylc install to "re-source" the workflow from the given directory (which would be a follow-up issue).
|
Just ran into this bug again, would be good to get it resolved soon |
oliver-sanders
requested review from
wxtim
and removed request for
oliver-sanders
Change error message for changed source dir
datamel
force-pushed
the
source-sym-fix
branch
from
f88f491 to
de7e537
Compare
CHANGES.md
Outdated
| [#4319](https://github.com/cylc/cylc-flow/pull/4319) - | ||
| Update cylc reinstall to skip cylc dirs work and share #4319 | ||
|
|
There was a problem hiding this comment.
| [#4319](https://github.com/cylc/cylc-flow/pull/4319) - | |
| Update cylc reinstall to skip cylc dirs work and share #4319 |
Already exists at lines 96-7 above, which I think is the right place for it.
There was a problem hiding this comment.
Happy with it to merge.
However, going back to the example I commented earlier (sorry!)
- Create
~/cylc-src/test/flow.cylc$ cylc install test- Delete the
~/cylc-src/test/dir- Create
~/Documents/test/flow.cylc(or wherever, doesn't have to be in Documents).$ cylc install -C ~/Documents/test
The warning message
WorkflowFilesError: Workflow source dir is not accessible: ~/cylc-src/test".
Restore the source or modify the "~/cylc-run/test/_cylc-install/source"
symlink to continue.
might not be so helpful in this case, and I wonder if the Source directory not consistent between runs message should take precedence instead.
Up to you if you want to address this
|
I'm gonna merge this - thanks @datamel 👍 and post a "small" issue to review the wording of installation-related error messages. |
These changes close #4322
CONTRIBUTING.mdand added my name as a Code Contributor.setup.pyandconda-environment.yml.