Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/f: fix flaky test api-workflow-info #4361

Merged
merged 2 commits into from
Aug 16, 2021
Merged

tests/f: fix flaky test api-workflow-info #4361

merged 2 commits into from
Aug 16, 2021

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Aug 16, 2021 •
edited
Loading

  • Fix flaky test by sorting config component of get_graph_raw output.
  • Replace custom script with the cylc client command.
    • Tests have always failed on my platform for some environment reason.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.py and
    conda-environment.yml.
  • Appropriate tests are included (unit and/or functional).
  • No change log entry required (why? e.g. invisible to users).
  • No documentation update required.

@oliver-sanders
tests/f: simplify api-workflow-info
fcfe400 
* replace custom script with the cylc client command
@oliver-sanders oliver-sanders added this to the cylc-8.0b3 milestone Aug 16, 2021
@oliver-sanders oliver-sanders self-assigned this Aug 16, 2021
@oliver-sanders oliver-sanders mentioned this pull request Aug 16, 2021
Merged
11 tasks
@oliver-sanders oliver-sanders changed the title tests/f: simplify api-workflow-info tests/f: fix flaky test api-workflow-info Aug 16, 2021
@oliver-sanders
tests/f: api-suite-info/00 - de-flaky test
954b5ce 
* fix sort order of config items in output
@hjoliver
Copy link
Member

Brilliant, thanks @oliver-sanders

@hjoliver
Copy link
Member

The failing test is unrelated, it also just started failing on my optional outputs branch:

tests/unit/test_workflow_files.py on Ubuntu Python 3.7 only

It passes with 3.7 locally

hjoliver
hjoliver approved these changes Aug 16, 2021
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm ✨

@hjoliver hjoliver merged commit 1a297ec into cylc:master Aug 16, 2021
@oliver-sanders oliver-sanders deleted the api-suite-info branch August 17, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
small
Projects
None yet
Milestone
cylc-8.0b3
Development

Successfully merging this pull request may close these issues.
2 participants
@oliver-sanders @hjoliver