Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update filenames in the log directory [small, but can be pushed to rc1 if it doens't make b3] #4430

Merged
merged 4 commits into from
Sep 27, 2021
Merged

Update filenames in the log directory [small, but can be pushed to rc1 if it doens't make b3] #4430

merged 4 commits into from
Sep 27, 2021

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Sep 23, 2021

These changes partially address #4407

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Already covered by existing tests.
  • Appropriate change log entry included.

@wxtim wxtim self-assigned this Sep 23, 2021
@wxtim wxtim added the small label Sep 23, 2021
@wxtim wxtim added this to the cylc-8.0b3 milestone Sep 23, 2021
@wxtim wxtim changed the title Update filenames in the log directory Update filenames in the log directory [small, but can be pushed to rc1 if it doens't make b3] Sep 23, 2021
@wxtim wxtim mentioned this pull request Sep 23, 2021
Merged
7 tasks
@wxtim wxtim requested review from hjoliver, dpmatthews and datamel and removed request for dpmatthews September 23, 2021 15:37
hjoliver
hjoliver approved these changes Sep 24, 2021
View reviewed changes
cylc/flow/scheduler.py Outdated Show resolved Hide resolved
datamel
datamel approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@datamel datamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have read the code, checked out the branch and run the tests. I am aware that the tests are not passing CI but I think this is unrelated.

@datamel datamel merged commit 7eb7fe9 into cylc:master Sep 27, 2021
@wxtim wxtim deleted the fix.log-file-names branch September 27, 2021 10:50
@wxtim wxtim mentioned this pull request Oct 15, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamel datamel datamel approved these changes

@hjoliver hjoliver hjoliver approved these changes

Assignees

@wxtim wxtim

Labels
small
Projects
None yet
Milestone
cylc-8.0b3
Development

Successfully merging this pull request may close these issues.
3 participants
@wxtim @hjoliver @datamel