Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

~_W'FLOW_NAME ⇒ ~_W'FLOW_ID and ~_W'FLOW_NAME re-instated as Cylc7 consistent #4455

Merged
merged 14 commits into from
Oct 11, 2021
Merged

~_W'FLOW_NAME ⇒ ~_W'FLOW_ID and ~_W'FLOW_NAME re-instated as Cylc7 consistent #4455

merged 14 commits into from
Oct 11, 2021

Commits on Oct 6, 2021

  1. write test for new WORKFLOW_ID=foo/run1 and WORKFLOW_NAME=foo

    @wxtim
    wxtim committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    0208942 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2021

  1. Renamed CYLC_WORKFLOW_NAME ⇒ CYLC_WORKFLOW_ID 

    Made CYLC_WORKFLOW_ID = CYLC_WORKFLOW_NAME - trailing "runX"
    @wxtim
    wxtim committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    85d7534 View commit details
    Browse the repository at this point in the history

  2. allow test_header init_workflow to set whether to use --no-run-name

    @wxtim
    wxtim committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    0aefd60 View commit details
    Browse the repository at this point in the history

  3. fixed test for CYLC_WORKFLOW_ID

    @wxtim
    wxtim committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    0a3bbbd View commit details
    Browse the repository at this point in the history

  4. CHANGES.md added

    @wxtim
    wxtim committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    56695ca View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
    @wxtim @MetRonnie
    wxtim and MetRonnie authored Oct 7, 2021
    Configuration menu
    Copy the full SHA
    e76b043 View commit details
    Browse the repository at this point in the history

  6. remove unwanted files; add documentation for change to init_workflow

    @wxtim
    wxtim committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    a48be6f View commit details
    Browse the repository at this point in the history

  7. finished rename of runN_remover

    @wxtim
    wxtim committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    ba37e34 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2021

  1. added docstring as per @MetRonnie suggestion

    @wxtim
    wxtim committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    33ae4ae View commit details
    Browse the repository at this point in the history

  2. remove accidental PR pollution

    @wxtim
    wxtim committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    bbded6e View commit details
    Browse the repository at this point in the history

  3. replaced refs in script docstrings to REG to WORKFLOW/ID/NAME

    @wxtim
    wxtim committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    2b802cd View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
    @wxtim @MetRonnie
    wxtim and MetRonnie authored Oct 11, 2021
    Configuration menu
    Copy the full SHA
    c51526f View commit details
    Browse the repository at this point in the history

  2. Fixed some review comments; fixed cylc play docstring!

    @wxtim
    wxtim committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    27bcc5a View commit details
    Browse the repository at this point in the history

  3. fix test reliant on REG

    @wxtim
    wxtim committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    b6ff733 View commit details
    Browse the repository at this point in the history