Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Parsec ItemNotFoundError into two #4471

Merged
merged 18 commits into from
Nov 16, 2021
Merged

Commits on Oct 19, 2021

  1. Separate Parsec ItemNotFoundError into two

    ItemNotFoundError - Where an item could be defined, but isn't (in sparse mode).
    NotAConfigItemError - Where an item is not part of a config to be defined.
    
    move get_manyparents to init
    
    create unit test for get_manyparents
    
    fix mypy issue
    wxtim committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    08155bf View commit details
    Browse the repository at this point in the history
  2. Update cylc/flow/parsec/exceptions.py

    Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
    wxtim and oliver-sanders authored Oct 19, 2021
    Configuration menu
    Copy the full SHA
    cf33544 View commit details
    Browse the repository at this point in the history
  3. Apply suggestions from code review

    Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
    wxtim and oliver-sanders authored Oct 19, 2021
    Configuration menu
    Copy the full SHA
    73c1568 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3ec13e1 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2021

  1. Update CHANGES.md

    Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
    wxtim and MetRonnie authored Oct 25, 2021
    Configuration menu
    Copy the full SHA
    cd27c3e View commit details
    Browse the repository at this point in the history
  2. Update cylc/flow/parsec/config.py

    Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
    wxtim and MetRonnie authored Oct 25, 2021
    Configuration menu
    Copy the full SHA
    5bb4250 View commit details
    Browse the repository at this point in the history
  3. fixed logic

    wxtim committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    2596840 View commit details
    Browse the repository at this point in the history
  4. fixed test

    wxtim committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    054c49b View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2021

  1. fixed the logic futher

    wxtim committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    1cf2634 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2021

  1. Configuration menu
    Copy the full SHA
    c3a5d14 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2021

  1. Apply suggestions from code review

    Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
    wxtim and MetRonnie authored Nov 2, 2021
    Configuration menu
    Copy the full SHA
    0524869 View commit details
    Browse the repository at this point in the history
  2. review response

    wxtim committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    0a47fdd View commit details
    Browse the repository at this point in the history
  3. Merge branch 'config.fix' of github.com:wxtim/cylc into config.fix

    * 'config.fix' of github.com:wxtim/cylc: (71 commits)
      Apply suggestions from code review
      Tweak TUI job prep state icon.
      Reduce test flakiness on MacOS
      Fix logging of task state transistion to "preparing".
      Fix datastore job "preparing" state.
      Fix TUI job "preparing" state.
      Fix spelling error.
      Func test fix.
      Style fix.
      Workflow config doc refinements (cylc#4475)
      Update cylc/flow/cfgspec/workflow.py
      Fix two func tests, and a typo.
      Remove CYLC_WORKFLOW_DEF_PATH
      Address review feedback (tweak some docstrings).
      Update cylc/flow/task_pool.py
      Post rebase fix.
      Set flow counter from DB.
      Fix a func test post rebase.
      Fix cylc poll CLI doc.
      Add nosec comment.
      ...
    wxtim committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    de0da57 View commit details
    Browse the repository at this point in the history
  4. fix flake 8

    wxtim committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    eda55aa View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2021

  1. Configuration menu
    Copy the full SHA
    ceab310 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    83dbaf0 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. Merge pull request #32 from MetRonnie/patch-pr-4471

    Simplify `ParsecConfig.get()`
    wxtim authored Nov 15, 2021
    Configuration menu
    Copy the full SHA
    4a122b9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9a07734 View commit details
    Browse the repository at this point in the history