Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove CYLC_WORKFLOW_NAME from many tests #4472

Merged

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Oct 19, 2021

Another follow up to #4455 : Response to @oliver-sanders review.

Up against beta 3 because it probably doesn't make sense to have #4455 in but not this.

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.py and
    conda-environment.yml.
  • Does not need tests (Changes to tests).
  • No change log entry required (Covered by ~_W'FLOW_NAME~_W'FLOW_ID and ~_W'FLOW_NAME re-instated as Cylc7 consistent #4455 )
  • No documentation update required.

@wxtim wxtim marked this pull request as draft October 19, 2021 10:33
@wxtim wxtim self-assigned this Oct 20, 2021
@wxtim wxtim added the small label Oct 20, 2021
@wxtim wxtim added this to the cylc-8.0b3 milestone Oct 20, 2021
@wxtim wxtim marked this pull request as ready for review October 20, 2021 09:42
@hjoliver hjoliver merged commit ae4934e into cylc:master Oct 20, 2021
@MetRonnie MetRonnie removed their request for review October 21, 2021 08:36
@wxtim wxtim deleted the Yet_another-CYLC_WORKFLOW_NAME-replacement branch March 22, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants