Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the suite.rc flow.cylc symlink #4506

Merged
merged 13 commits into from
Dec 3, 2021
Merged

Remove the suite.rc flow.cylc symlink #4506

merged 13 commits into from
Dec 3, 2021

Commits on Nov 29, 2021

  1. Remove the suite.rc flow.cylc symlink

    @datamel
    datamel committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    9f401fe View commit details
    Browse the repository at this point in the history

  2. change log

    @datamel
    datamel committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    c14db21 View commit details
    Browse the repository at this point in the history

  3. shellcheck

    @datamel
    datamel committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    a4354b6 View commit details
    Browse the repository at this point in the history

  4. Review feedback and add checks to suite.rc and flow.cylc file logic.

    @datamel
    datamel committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    d638b3e View commit details
    Browse the repository at this point in the history

  5. Update cylc/flow/workflow_files.py 

    Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
    @datamel @MetRonnie
    datamel and MetRonnie committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    e42f548 View commit details
    Browse the repository at this point in the history

  6. Add test and tweak logic to permit symlinks elsewhere for flow.cylc file 

    add test for deprecation message cylc install
    @datamel
    datamel committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    0beeac4 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2021

  1. Update tests/unit/test_workflow_files.py 

    Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
    @datamel @MetRonnie
    datamel and MetRonnie authored Nov 30, 2021
    Configuration menu
    Copy the full SHA
    a49283c View commit details
    Browse the repository at this point in the history

  2. dedent test

    @datamel
    datamel committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    90f2693 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'remove-suite-flow-symlink' of github.com:datamel/cylc-f… 

    …low into remove-suite-flow-symlink
    @datamel
    datamel committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    8d55298 View commit details
    Browse the repository at this point in the history

  4. Fix test

    @datamel
    datamel committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    97fab79 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2021

  1. Update cylc/flow/workflow_files.py 

    Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
    @wxtim @MetRonnie
    wxtim and MetRonnie authored Dec 2, 2021
    Configuration menu
    Copy the full SHA
    6e4895c View commit details
    Browse the repository at this point in the history

  2. Change logic comparing symlinked flow.cylc file.

    @datamel
    datamel committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    5484cb6 View commit details
    Browse the repository at this point in the history

  3. logic fix

    @datamel
    datamel committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    46d7737 View commit details
    Browse the repository at this point in the history