-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
actually load contact info before sending a task message. #4518
actually load contact info before sending a task message. #4518
Conversation
e8816b6
to
95f183f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I haven't yet tested it.
Damn, we need another Cylc 7 release. |
We could do with putting this in it too: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have read the code, checked out the branch and run with a test suite.
I can confirm the branch works as expected and I am happy with the change.
Special thanks to @wxtim for providing me with his test suite and the tips on getting it up and running!
I will leave the merge for you to finish tests @oliver-sanders. I've done a manual check but you may wish to do one yourself. |
It was Dave's test suite. |
This is a small change with no associated Issue - description of issue here:
@dpmatthews noticed that a remote platform was not picking up custom settings for task messaging. It appears that these settings aren't loaded from the contact file before they are set for the task messaging app.
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.setup.py
andconda-environment.yml
.