Disallow run n and run x as flow names #4526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
changed the title
wxtim
requested review from
MetRonnie and
datamel
and removed request for
datamel
MetRonnie
reviewed
Nov 23, 2021
MetRonnie
reviewed
Nov 23, 2021
wxtim
force-pushed
the
disallow_runN_and_runX_as_flow-names
branch
from
b1750d0
to
3690653
Compare
wxtim
commented
Nov 24, 2021
wxtim
force-pushed
the
disallow_runN_and_runX_as_flow-names
branch
from
234be0f
to
9123245
Compare
MetRonnie
reviewed
Nov 25, 2021
| @@ -1311,7 +1311,7 @@ def _parse_src_reg(reg: Path, cur_dir_only: bool = False) -> Tuple[Path, Path]: | |||
| return (reg, abs_path) | |||
|
|
|||
|
|
|||
| def validate_workflow_name(name: str) -> None: | |||
| def validate_workflow_name(name: str, runNcheck=False) -> None: | |||
There was a problem hiding this comment.
Why do we need this runNcheck argument?
There was a problem hiding this comment.
Other commands that use validate_workflow_name can (sometimes should) be passed a name which ends in runN or runX:
Consider cylc clean /home/me/cylc-run/my-workflow/runN. Cylc clean uses validate workflow, and in that case it certainly doesn't want to claim that /home/me/cylc-run/my-workflow/runN is not valid.
Cylc play is the other use case.
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
MetRonnie
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4394 - IMO a single reviewer PR.
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.setup.pyandconda-environment.yml.