Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

job-script: run the global init-script before sourcing the job script #4534

Merged
merged 2 commits into from
Dec 14, 2021
Merged

job-script: run the global init-script before sourcing the job script #4534

merged 2 commits into from
Dec 14, 2021

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Nov 26, 2021 •
edited
Loading

  • Closes allow jobs to run on a compute node with no $HOME #4520
  • Allows jobs to be run on machienes which don't have a home directory
    by setting $HOME in the global init-script.
  • This comes with some caveats:
    • The global init-script will no longer be covered by error trapping.
    • The job environment will no longer be available to the global init-script.
    • In debug mode the global init-script will not be included in xtrace output.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.py and
    conda-environment.yml.
  • Appropriate tests are included (unit and/or functional).
  • Appropriate change log entry included.
  • (master branch) I have opened a documentation PR at platforms: document how to run jobs on a homeless platform. cylc-doc#344

@oliver-sanders oliver-sanders added this to the cylc-8.0rc1 milestone Nov 26, 2021
@oliver-sanders oliver-sanders self-assigned this Nov 26, 2021
@oliver-sanders oliver-sanders mentioned this pull request Nov 26, 2021
Merged
@dpmatthews dpmatthews self-requested a review November 26, 2021 17:32
hjoliver
hjoliver reviewed Dec 7, 2021
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of comments on docs.

cylc/flow/cfgspec/globalcfg.py Outdated Show resolved Hide resolved
cylc/flow/cfgspec/globalcfg.py Outdated Show resolved Hide resolved
cylc/flow/cfgspec/globalcfg.py Outdated Show resolved Hide resolved
dpmatthews
dpmatthews requested changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@dpmatthews dpmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Just needs one redundant line removing from job.sh.

cylc/flow/job_file.py Show resolved Hide resolved
@hjoliver
Copy link
Member

hjoliver commented Dec 9, 2021

(Small flake8 fail, change log conflict, and one of my comments on "job file sourced" is still extant).

@oliver-sanders
job-script: run the global init-script before sourcing the job script
cc63bc4 
* Closes cylc#4520
* Allows jobs to be run on machienes which don't have a home directory
  by setting $HOME in the global init-script.
* This comes with some caveats:
  * The global init-script will no longer be covered by error trapping.
  * The job environment will no longer be available to the global init-script.
  * In debug mode the global init-script will not be included in xtrace output.
@oliver-sanders
Copy link
Member Author

Done.

@hjoliver hjoliver merged commit b1519f5 into cylc:master Dec 14, 2021
@oliver-sanders oliver-sanders deleted the 4520.homeless-jobs branch December 15, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

@dpmatthews dpmatthews dpmatthews approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
None yet
Projects
None yet
Milestone
cylc-8.0rc1
Development

Successfully merging this pull request may close these issues.

allow jobs to run on a compute node with no $HOME
3 participants
@oliver-sanders @hjoliver @dpmatthews