Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix job submit time delta. #4553

Merged
merged 5 commits into from
Dec 17, 2021
Merged

Fix job submit time delta. #4553

merged 5 commits into from
Dec 17, 2021

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented Dec 9, 2021

These changes close #4551

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Appropriate tests are included
    - (tweaked a func test to check start and submit times get into the datastore).
  • Appropriate change log entry included.
  • No documentation update required.

@hjoliver hjoliver added the bug Something is wrong :( label Dec 9, 2021
@hjoliver hjoliver added this to the cylc-8.0rc1 milestone Dec 9, 2021
@hjoliver hjoliver self-assigned this Dec 9, 2021
@hjoliver
Copy link
Member Author

hjoliver commented Dec 9, 2021

This also populates job submit and start time in simulation mode.

shot

@hjoliver hjoliver force-pushed the fix-job-submit-delta branch 2 times, most recently from 4ae493f to 78a7436 Compare December 10, 2021 00:06
Copy link
Member

@dwsutherland dwsutherland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Works locally (is that an unrelated test failure, or not?)..

@hjoliver
Copy link
Member Author

Works locally (is that an unrelated test failure, or not?)..

Related; this change exposed a bug (task proxy .jobs wasn't being copied over on reload). Fixed.

@wxtim wxtim self-requested a review December 16, 2021 21:17
@wxtim wxtim merged commit 5169362 into cylc:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Job submitted time missing
3 participants