Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate timestamps from logging #4560

Closed
wants to merge 1 commit into from

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Dec 21, 2021

These changes partially address #3647

TODO

  • Need to keep the time if comms method is poll

  • Remove second timestamp if comms method is not poll.

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.

  • Contains logically grouped changes (else tidy your branch by rebase).

  • Does not contain off-topic changes (use other PRs for other changes).

  • Applied any dependency changes to both setup.cfg and conda-environment.yml.

  • Already covered by existing tests: I suspect any test grepping for this will pass without change because this change removes redundancy.

  • No change log entry required (Small Logging Change).

  • No documentation update required.

@wxtim wxtim requested a review from hjoliver December 21, 2021 10:27
@wxtim wxtim marked this pull request as draft December 21, 2021 10:48
@wxtim wxtim closed this Dec 21, 2021
@wxtim wxtim deleted the logging_cleanup branch March 22, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant