Fix host selection bug for deprecated [runtime][<task>][remote]host syntax
#4570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid selecting localhost if host specified using deprecated `[runtime][<task>][remote]host` can't be reached
MetRonnie
commented
Jan 6, 2022
| @@ -288,16 +288,18 @@ def submit_task_jobs(self, workflow, itasks, curve_auth, | |||
|
|
|||
| # Get another platform, if task config platform is a group | |||
| use_next_platform_in_group = False | |||
| try: | |||
| platform = get_platform( | |||
| itask.tdef.rtconfig['platform'], | |||
There was a problem hiding this comment.
Problem was itask.tdef.rtconfig['platform'] is None so get_platform() fell back to the localhost platform
wxtim
approved these changes
Jan 6, 2022
MetRonnie
changed the title
[runtime][<task>][remote]host syntax[runtime][<task>][remote]host syntax
oliver-sanders
approved these changes
Jan 17, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes close #4569
Prevent Cylc from incorrectly falling back to localhost if a host specified by
[runtime][<task>][remote]hostis unreachable.Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfgandconda-environment.yml.