Wrapper script enhancements #4655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
reviewed
Feb 7, 2022
… flow version (e.g. cylc-8.0.0-1) Ensure workflows always run under fixed environments rather than symlinked versions which could change Provide legacy support for rose edit & cylc review (partially address cylc#4555)
wxtim
approved these changes
Feb 8, 2022
hjoliver
reviewed
Feb 24, 2022
Comment on lines
+70
to
+71
| # Releases should be installed into environments in the ROOT location, named | ||
| # cylc-$CYLC_VERSION. We recommend using the cylc-flow version plus an additional |
There was a problem hiding this comment.
A small change would be handy at NIWA, to avoid having to edit some code down in the guts of the wrapper:
CYLC_ENV_NAME_PREFIX="cylc-" # editable prefix
# ...
${CYLC_ENV_NAME_PREFIX}${CYLC_VERSION}
Our HPC admins use this convention: .../share/cylc/8.0rc1 etc.
There was a problem hiding this comment.
I like this idea. However, I think it also means making the name of the default version configurable (also like the idea of this). Do you mind if we do this in a separate PR?
There was a problem hiding this comment.
See #4555 (comment)
oliver-sanders
approved these changes
Mar 9, 2022
|
Is there any reason why this has stopped? |
|
Probably my fault - I had meant to approve, aside from the change suggestion above that I agreed (via 👍 ) to punt to another issue. |
hjoliver
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the use of environments with names that do not match the cylc flow version (e.g. cylc-8.0.0-1)
Ensure workflows always run under fixed environments rather than symlinked versions which could change
Provide legacy support for rose edit & cylc review (partially address #4555)