-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check job not in prep already before triggering. #4667
Conversation
I'm not sure we can reliably/repeatedly test this. Tasks do not stay in the |
(unrelated flaky test failure) |
Looks good, makes sense. This is the sort of thing we should be able to cover with an integration test, I'll take a look... ... done. |
e77421e
to
8580e12
Compare
8580e12
to
74a504c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed the new test fails on master, passes on this branch
Nice test, thanks @oliver-sanders |
These changes close #4665
Don't retrigger a task that is already preparing for job submission.
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
andconda-environment.yml
.