Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for databases with empty WORKFLOW_PARAMS table on workflow shut… #4679

Closed
wants to merge 4 commits into from
Closed

check for databases with empty WORKFLOW_PARAMS table on workflow shut… #4679

wants to merge 4 commits into from

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Feb 11, 2022

…down and restart.

These changes close #4637

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Appropriate tests are included (unit and/or functional).
  • Appropriate change log entry included.
  • No documentation update required.

@wxtim wxtim added this to the cylc-8.0rc2 milestone Feb 11, 2022
@wxtim wxtim requested a review from MetRonnie February 11, 2022 12:55
@wxtim wxtim self-assigned this Feb 11, 2022
@wxtim wxtim marked this pull request as draft February 11, 2022 14:39
@wxtim wxtim closed this Feb 11, 2022
@MetRonnie
Copy link
Member

Why have you closed this?

@wxtim
Copy link
Member Author

wxtim commented Feb 14, 2022

Why have you closed this?

Replaced by #4680

@oliver-sanders oliver-sanders removed this from the cylc-8.0rc2 milestone Feb 14, 2022
@wxtim wxtim deleted the check_for_empty_workflow_params_in_db branch October 10, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MetRonnie MetRonnie Awaiting requested review from MetRonnie

Assignees

@wxtim wxtim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Giving an invalid --stopcp on start "corrupts" database
3 participants
@wxtim @MetRonnie @oliver-sanders