Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release: 8.0rc2 #4753

Merged
merged 3 commits into from
Mar 23, 2022
Merged

Prepare release: 8.0rc2 #4753

merged 3 commits into from
Mar 23, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 23, 2022

⚡ Merging this PR will automatically create a GitHub Release & publish the package ⚡

This PR was created by the Release stage 1 - create release PR (Cylc 8+ only) workflow, triggered by @datamel

Tests:

  • Tests last run on master: test_fast.yml test_functional.yml bash.yml test_manylinux.yml
  • ✔️ Build check passed - see the workflow run (number 9) for more info

Checklist:

  • Milestone complete?
    0 other open issues/PRs on milestone cylc-8.0rc2 at time of PR creation
  • Changelog up-to-date?
    • Examine pull requests made since the last release
    • "Released on" date updated? ✔️ 2022-03-23

Next steps:

  • @datamel should request 1 or 2 reviews
  • If any further changes are needed, push to this PR branch
  • After merging, the bot will comment below with a link to the release (if not, look at the PR checks tab)

Workflow: Release stage 1 - create release PR (Cylc 8+ only), run: 9
@github-actions github-actions bot added this to the cylc-8.0rc2 milestone Mar 23, 2022
@github-actions github-actions bot added the release Warning: for release PRs only. Merging this PR will trigger GH Actions to publish. label Mar 23, 2022
CHANGES.md Outdated
Comment on lines 36 to 37
Note: Cylc 8 beta users will not be able to restart workflows run with previous Cylc 8 pre-releases due to changes in the workflow database structure.

Copy link
Member

@MetRonnie MetRonnie Mar 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I not sure we need this note, it perhaps suggests you won't be able to restart 8.0rc1 workflows but you can. If users jumping from a beta version to rc2 want to see what's changed, they should also read the changelog for rc1 imo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it because, due to the close timeframes of the releases, I thought users may find this useful information to have on hand if they pick up this release, skipping rc1. Happy to change the wording to pre-rc releases or remove if you feel strongly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted.

This reverts commit a8f64c2.
Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Test failures are due to MacOS runner flakiness)

@oliver-sanders
Copy link
Member

MacOS runner flakiness

I think this is most likely caused by a genuine issue in resource release.

@datamel datamel merged commit aff9fc6 into master Mar 23, 2022
@github-actions
Copy link
Contributor Author

✔️ success

Next steps for @datamel:


Comment created by workflow: Release stage 2 - auto publish, run: 20

@github-actions github-actions bot deleted the prepare-8.0rc2 branch March 23, 2022 12:38
@MetRonnie
Copy link
Member

I think this is most likely caused by a genuine issue in resource release.

It didn't even get to the integration tests though, brew install took nearly 10 out of the 15 minutes allowed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Warning: for release PRs only. Merging this PR will trigger GH Actions to publish.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants