Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape quotes in remote command args. #4769

Merged
merged 3 commits into from
Apr 1, 2022
Merged

Escape quotes in remote command args. #4769

merged 3 commits into from
Apr 1, 2022

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented Mar 25, 2022 •
edited
Loading

These changes close #4760

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Appropriate tests are included (unit).
  • Appropriate change log entry included.
  • No documentation update required.

@hjoliver hjoliver self-assigned this Mar 25, 2022
@hjoliver hjoliver added bug Something is wrong :( small labels Mar 25, 2022
@hjoliver hjoliver added this to the cylc-8.0rc3 milestone Mar 25, 2022
@hjoliver hjoliver marked this pull request as draft March 25, 2022 04:31
@hjoliver hjoliver force-pushed the fix-remote-play branch 4 times, most recently from 5bbd787 to 8e885f4 Compare March 28, 2022 00:41
@hjoliver hjoliver marked this pull request as ready for review March 28, 2022 02:02
@hjoliver hjoliver mentioned this pull request Mar 31, 2022
Closed
@hjoliver
Copy link
Member Author

hjoliver commented Apr 1, 2022

One review will do for this tiny change.

@hjoliver hjoliver merged commit 1c0084d into cylc:master Apr 1, 2022
@hjoliver hjoliver deleted the fix-remote-play branch April 1, 2022 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders oliver-sanders approved these changes

@dpmatthews dpmatthews Awaiting requested review from dpmatthews

Assignees

@hjoliver hjoliver

Labels
bug Something is wrong :( small
Projects
None yet
Milestone
cylc-8.0rc3
Development

Successfully merging this pull request may close these issues.

cylc play --set not working in combination with [scheduler][run hosts]
2 participants
@hjoliver @oliver-sanders