xtriggers: reinstate Cylc 7 template variables #4777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-sanders
added a commit
to oliver-sanders/cylc-doc
that referenced
this pull request
Mar 25, 2022
* Sibling: cylc/cylc-flow#4777 * Requires: cylc#422
1 task
* Closes cylc#4757 * Reinstate Cylc 7 xtrigger template variables with deprecation warnings to allow 7/8 compativle xtrigger definitions. * Deprecate `workflow_name` in favor of `workflow` for consistency with event template variables (and because it's `workflow_id` not `workflow_name`). * Raise a special xtrigger config exception that inheritc from CylcError rather than primitive exceptions so make errors format more nicely on the CLI.
hjoliver
reviewed
Mar 28, 2022
I did this because it looks like we have a few RC users out there and didn't want to re-mess-up their workflows. |
hjoliver
approved these changes
Mar 31, 2022
oliver-sanders
added a commit
to oliver-sanders/cylc-doc
that referenced
this pull request
Apr 6, 2022
* Sibling: cylc/cylc-flow#4777 * Requires: cylc#422
wxtim
pushed a commit
to cylc/cylc-doc
that referenced
this pull request
Apr 6, 2022
* Sibling: cylc/cylc-flow#4777 * Requires: #422
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workflow_namein favor ofworkflowfor consistency with event template variables (and because it'sworkflow_idnotworkflow_name).Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfgandconda-environment.yml.