Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: log command failures at error level #4793

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

oliver-sanders
Copy link
Member

Spotted whilst reviewing: #4720

Command errors are logged at the warning level rather than error. These errors aren't CRITICAL (they don't tear down the scheduler), but they are a bit more important than the WARNING level which makes it harder to pick them out in the logs.

Also combine two log entries into one for clarity.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Does not need tests (why?).
  • No change log entry required (why? e.g. invisible to users).
  • No documentation update required.

@oliver-sanders oliver-sanders added the could be better Not exactly a bug, but not ideal. label Mar 31, 2022
@oliver-sanders oliver-sanders added this to the cylc-8.0rc3 milestone Mar 31, 2022
@oliver-sanders oliver-sanders self-assigned this Mar 31, 2022
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hjoliver hjoliver merged commit 60216da into cylc:master Mar 31, 2022
@hjoliver
Copy link
Member

hjoliver commented Mar 31, 2022

Oops, premature merge. Broke a couple of integration tests on master. Investigating...

... fix #4794

@hjoliver hjoliver mentioned this pull request Apr 1, 2022
@oliver-sanders oliver-sanders deleted the command-failed branch April 1, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
could be better Not exactly a bug, but not ideal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants