Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add File Installlation to Reload #4797

Merged
merged 3 commits into from
Apr 4, 2022
Merged

Add File Installlation to Reload #4797

merged 3 commits into from
Apr 4, 2022

Conversation

datamel
Copy link
Contributor

@datamel datamel commented Apr 4, 2022 •
edited
Loading

These changes close #4787

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Appropriate tests are included (unit and/or functional).
  • Appropriate change log entry included.
  • (master branch) I have opened a documentation PR at Reload triggers remote file installation documentation cylc-doc#452

@datamel datamel added the bug Something is wrong :( label Apr 4, 2022
@datamel datamel added this to the cylc-8.0rc3 milestone Apr 4, 2022
@datamel datamel self-assigned this Apr 4, 2022
oliver-sanders
oliver-sanders reviewed Apr 4, 2022
View reviewed changes
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good:

cylc/flow/scripts/reload.py Outdated Show resolved Hide resolved
oliver-sanders
oliver-sanders approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested, worked as expected.

@datamel @oliver-sanders
Update cylc/flow/scripts/reload.py
cb87c57 
Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
@MetRonnie MetRonnie self-requested a review April 4, 2022 12:01
@datamel datamel mentioned this pull request Apr 4, 2022
Merged
1 task
@MetRonnie MetRonnie merged commit e9cf297 into cylc:master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MetRonnie MetRonnie MetRonnie approved these changes

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@datamel datamel

Labels
bug Something is wrong :(
Projects
None yet
Milestone
cylc-8.0rc3
Development

Successfully merging this pull request may close these issues.

Reload File Installation
3 participants
@datamel @oliver-sanders @MetRonnie