Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better scan workflow detection. #4830

Merged
merged 3 commits into from
Apr 21, 2022
Merged

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented Apr 21, 2022

Attempted do-over of scan workflow detection, after noticing that an old workflow definition (i.e. suite.rc) installed by Cylc 8 is invisible (to cylc scan) until you run it.

New logic based on new explanatory comments in the code, which I've verified by manual testing.

This is a small change with no associated Issue.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Appropriate tests are included (unit and/or functional).
  • Appropriate change log entry included.
  • No documentation update required.

@hjoliver hjoliver added the bug Something is wrong :( label Apr 21, 2022
@hjoliver hjoliver added this to the cylc-8.0rc3 milestone Apr 21, 2022
@hjoliver hjoliver self-assigned this Apr 21, 2022
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers.

@oliver-sanders oliver-sanders merged commit af39199 into cylc:master Apr 21, 2022
@hjoliver hjoliver deleted the scan-c7-fix branch April 21, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants