Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop a few more deprecation warnings in backward compatibility mode #4850

Merged
merged 1 commit into from
May 4, 2022
Merged

Stop a few more deprecation warnings in backward compatibility mode #4850

merged 1 commit into from
May 4, 2022

Conversation

MetRonnie
Copy link
Member

These ones slipped through the net in #4829

This is a small change with no associated Issue.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Does not need tests
  • No change log entry required
  • No documentation update required.

@MetRonnie MetRonnie added small could be better Not exactly a bug, but not ideal. labels May 4, 2022
@MetRonnie MetRonnie added this to the cylc-8.0rc3 milestone May 4, 2022
@MetRonnie MetRonnie self-assigned this May 4, 2022
oliver-sanders
oliver-sanders approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@oliver-sanders oliver-sanders left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliver-sanders oliver-sanders merged commit 614194e into cylc:master May 4, 2022
@MetRonnie MetRonnie deleted the back-compat-warn branch May 4, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@MetRonnie MetRonnie

Labels
could be better Not exactly a bug, but not ideal. small
Projects
None yet
Milestone
cylc-8.0rc3
Development

Successfully merging this pull request may close these issues.
2 participants
@MetRonnie @oliver-sanders