auto restart plugin issues #4873
Comments
The issue here being the "traceback" part not the "each time the plugin is run". |
oliver-sanders
added a commit
to oliver-sanders/cylc-flow
that referenced
this issue
Jun 6, 2022
* Addresses cylc#4873 * There is now a default main loop plugin interval of `PT10M`. This prevents any plugins without a hardcoded default from being run with every main loop cycle. * Explicitly set a default for the `auto restart` plugin (also `PT10M`). * Added a note on enabling plugins. * Suppress traceback from reloading the global config in the `auto restart` plugin. This is now logged nicely. * Prevent plugins from being loaded twice when specified both on the CLI (--main-loop) and in the config (global.cylc[scheduler][main loop]plugins).
oliver-sanders
added a commit
to oliver-sanders/cylc-doc
that referenced
this issue
Jun 6, 2022
* Partially addresses cylc/cylc-flow#4873
This was referenced Jun 6, 2022
datamel
pushed a commit
that referenced
this issue
Jun 14, 2022
* main loop: improve defaults, docs and error handling * Addresses #4873 * There is now a default main loop plugin interval of `PT10M`. This prevents any plugins without a hardcoded default from being run with every main loop cycle. * Explicitly set a default for the `auto restart` plugin (also `PT10M`). * Added a note on enabling plugins. * Suppress traceback from reloading the global config in the `auto restart` plugin. This is now logged nicely. * Prevent plugins from being loaded twice when specified both on the CLI (--main-loop) and in the config (global.cylc[scheduler][main loop]plugins). * Apply suggestions from code review Co-authored-by: Hilary James Oliver <hilary.j.oliver@gmail.com> Co-authored-by: Hilary James Oliver <hilary.j.oliver@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are several problems with the auto restart main loop plugin:
It's default interval is not documented. True of other plugins as well (only health check and reset bad hosts are documented).
The default interval is every main loop! At Cylc 7 I think it was part of the health check (i.e. every PT10M by default).
If you modify your global config to contain an invalid setting (after workflow startup) you get a traceback in the workflow log each time the plugin is run.
It's not enabled by default (because it's fairly heavyweight). However, there is no mention of this in the documentation for
[scheduler]auto restart delay,[scheduler][run hosts]condemnedor[scheduler][run hosts]available; nor in the section on Workflow Migration.The text was updated successfully, but these errors were encountered: