Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main loop: improve defaults, docs and error handling #4904

Merged
merged 2 commits into from
Jun 14, 2022

Conversation

oliver-sanders
Copy link
Member

  • Closes auto restart plugin issues #4873
    (in combination with auto restart: add note about enabling plugin cylc-doc#475)
  • There is now a default main loop plugin interval of PT10M.
    This prevents any plugins without a hardcoded default from being run with every main loop cycle.
  • Explicitly set a default for the auto restart plugin (also PT10M).
  • Added a note on enabling plugins.
  • Suppress traceback from reloading the global config in the auto restart plugin.
    This is now logged nicely.
  • Prevent plugins from being loaded twice when specified both on the CLI
    (--main-loop) and in the config (global.cylc[scheduler][main loop]plugins).

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Appropriate tests are included (unit and/or functional).
  • No change log entry required (why? docs and minor improvements).
  • No documentation update required.

* Addresses cylc#4873
* There is now a default main loop plugin interval of `PT10M`.
  This prevents any plugins without a hardcoded default from being run
  with every main loop cycle.
* Explicitly set a default for the `auto restart` plugin (also `PT10M`).
* Added a note on enabling plugins.
* Suppress traceback from reloading the global config in the `auto restart`
  plugin. This is now logged nicely.
* Prevent plugins from being loaded twice when specified both on the CLI
  (--main-loop) and in the config (global.cylc[scheduler][main loop]plugins).
@oliver-sanders oliver-sanders added small doc Documentation labels Jun 6, 2022
@oliver-sanders oliver-sanders added this to the cylc-8.0rc4 milestone Jun 6, 2022
@oliver-sanders oliver-sanders self-assigned this Jun 6, 2022
@hjoliver hjoliver self-requested a review June 6, 2022 21:43
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Some minor comment and doc suggestions).

Co-authored-by: Hilary James Oliver <hilary.j.oliver@gmail.com>
@oliver-sanders oliver-sanders requested a review from datamel June 13, 2022 10:12
Copy link
Contributor

@datamel datamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code read, docs built and checked. Checked tests locally too. All good!

@datamel datamel merged commit dd6ba76 into cylc:master Jun 14, 2022
@oliver-sanders oliver-sanders deleted the 4873 branch June 14, 2022 10:41
@hjoliver hjoliver modified the milestones: cylc-8.0rc4, cylc-8.0.0 Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auto restart plugin issues
3 participants