-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cylc show: ignore past task prereqs #4874
Conversation
Tidy, plus don't report unsatisfied prerequisites for past tasks.
Also tidies |
1876c8e
to
8b9e835
Compare
(rc3 - because the linked issue is against that, and there's a slim chance this could get merged in time). |
cylc/flow/scripts/show.py
Outdated
@@ -18,7 +18,7 @@ | |||
|
|||
"""cylc show [OPTIONS] ARGS | |||
|
|||
Display workflow and task information. | |||
Display workflow and task information, for tasks in the datastore window. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
n=0 window? (I don't think users will understand the term datastore window)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's tasks in the current n-window (i.e. n=0 and n=1, by default). We need a term for the "datastore window". Maybe "data window" or "graph window" or "n-window". I'll go with the latter for now, and flag this as a discussion point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy with n-window
https://cylc.github.io/cylc-doc/nightly/html/glossary.html#term-window
Thanks @MetRonnie . I'll merge this with one approval to get it in rc3 (it is only a peripheral command, and it is well tested). |
These changes close #4036
cylc show
for past tasks loaded from the DB currently shows (incorrectly) unsatisfied prerequisites.It might occasionally be useful to see which of the prerequisites of a conditionally-triggered past task led to it triggering, but we can't do that without creating another DB history table. (DB refactor might solve this in the future: #3872 (comment))
For now, the simplest solution is for clients to ignore the prerequisites of past tasks, which is not entirely unreasonable given the purpose of task prerequisites. (Ignoring them server-side isn't trivial, without causing trouble when past tasks are retriggered).
See also: cylc/cylc-ui#1026
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
andconda-environment.yml
.