Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cylc show: ignore past task prereqs #4874

Merged
merged 11 commits into from
May 17, 2022

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented May 16, 2022

These changes close #4036

cylc show for past tasks loaded from the DB currently shows (incorrectly) unsatisfied prerequisites.

It might occasionally be useful to see which of the prerequisites of a conditionally-triggered past task led to it triggering, but we can't do that without creating another DB history table. (DB refactor might solve this in the future: #3872 (comment))

For now, the simplest solution is for clients to ignore the prerequisites of past tasks, which is not entirely unreasonable given the purpose of task prerequisites. (Ignoring them server-side isn't trivial, without causing trouble when past tasks are retriggered).

See also: cylc/cylc-ui#1026

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Already covered by existing tests.
  • Appropriate change log entry included.
  • No documentation update required.

Tidy, plus don't report unsatisfied prerequisites for past tasks.
@hjoliver hjoliver added the bug Something is wrong :( label May 16, 2022
@hjoliver hjoliver added this to the cylc-8.0rc4 milestone May 16, 2022
@hjoliver hjoliver self-assigned this May 16, 2022
@hjoliver
Copy link
Member Author

Also tidies cylc show output a bit. Result for the example here:

Screenshot from 2022-05-16 16-29-33

@hjoliver hjoliver changed the title Ignore past task prereqs cylc show: ignore past task prereqs May 16, 2022
@hjoliver hjoliver modified the milestones: cylc-8.0rc4, cylc-8.0rc3 May 16, 2022
@hjoliver
Copy link
Member Author

(rc3 - because the linked issue is against that, and there's a slim chance this could get merged in time).

@@ -18,7 +18,7 @@

"""cylc show [OPTIONS] ARGS

Display workflow and task information.
Display workflow and task information, for tasks in the datastore window.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n=0 window? (I don't think users will understand the term datastore window)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's tasks in the current n-window (i.e. n=0 and n=1, by default). We need a term for the "datastore window". Maybe "data window" or "graph window" or "n-window". I'll go with the latter for now, and flag this as a discussion point.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cylc/flow/scripts/show.py Outdated Show resolved Hide resolved
tests/functional/cylc-show/06-past-present-future.t Outdated Show resolved Hide resolved
@hjoliver
Copy link
Member Author

Thanks @MetRonnie . I'll merge this with one approval to get it in rc3 (it is only a peripheral command, and it is well tested).

@hjoliver hjoliver merged commit 3e6394b into cylc:master May 17, 2022
@hjoliver hjoliver deleted the ignore-past-task-prereqs branch May 17, 2022 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compute prerequisites for tasks outside n=0
2 participants