Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cylc 728 (with linter) #4900

Merged
merged 59 commits into from
Jul 27, 2022
Merged

Cylc 728 (with linter) #4900

merged 59 commits into from
Jul 27, 2022

Commits on Jul 4, 2022

  1. cylc linter

    @wxtim
    wxtim committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    b8377ad View commit details
    Browse the repository at this point in the history

  2. fixed: non indents on jinja2 OK

    @wxtim
    wxtim committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    e0df94e View commit details
    Browse the repository at this point in the history

  3. stuff

    @wxtim
    wxtim committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    ae550e4 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2022

  1. add documentation for API for pre and post install plugins.

    @wxtim
    wxtim committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    947cd72 View commit details
    Browse the repository at this point in the history

  2. Update CHANGES.md 

    Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
    @wxtim @MetRonnie
    wxtim and MetRonnie authored Jul 5, 2022
    Configuration menu
    Copy the full SHA
    1d023ad View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into cylc-linter

    @wxtim
    wxtim authored Jul 5, 2022
    Configuration menu
    Copy the full SHA
    b147c42 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into cylc-linter 

    * master:
  add documentation for API for pre and post install plugins.
    @wxtim
    wxtim committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    9a35f32 View commit details
    Browse the repository at this point in the history

  5. remove file added by mistake

    @wxtim
    wxtim committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    6358a21 View commit details
    Browse the repository at this point in the history

  6. undo mistaken reversions

    @wxtim
    wxtim committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    7407bf6 View commit details
    Browse the repository at this point in the history

  7. re-instated --reference mode; made doc not RST

    @wxtim
    wxtim committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    719404b View commit details
    Browse the repository at this point in the history

  8. added automated scraping of parsec upgraders

    @wxtim
    wxtim committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    94621aa View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2022

  1. wip - scraping obseletions

    @wxtim
    wxtim committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    d79bc6d View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2022

  1. stuff

    @wxtim
    wxtim committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    4631e80 View commit details
    Browse the repository at this point in the history

  2. re-written linter to use Cylc workflow config

    @wxtim
    wxtim committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    34ae482 View commit details
    Browse the repository at this point in the history

  3. updated tests to reflect all changes

    @wxtim
    wxtim committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    c79370f View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2022

  1. fix functional test

    @wxtim
    wxtim committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    50243d5 View commit details
    Browse the repository at this point in the history

  2. add test for config upgrader script

    @wxtim
    wxtim committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    079892b View commit details
    Browse the repository at this point in the history

  3. flake8

    @wxtim
    wxtim committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    5cdcb76 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2022

  1. Update cylc/flow/scripts/lint.py 

    Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
    @wxtim @MetRonnie
    wxtim and MetRonnie authored Jul 18, 2022
    Configuration menu
    Copy the full SHA
    ce88cc0 View commit details
    Browse the repository at this point in the history

  2. fix some issues

    @wxtim
    wxtim committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    0ea6523 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'cylc-linter' of github.com:wxtim/cylc into cylc-linter 

    * 'cylc-linter' of github.com:wxtim/cylc:
  Update cylc/flow/scripts/lint.py
    @wxtim
    wxtim committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    c223549 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
    @wxtim @MetRonnie
    wxtim and MetRonnie authored Jul 18, 2022
    Configuration menu
    Copy the full SHA
    ca6db34 View commit details
    Browse the repository at this point in the history

  5. uncommented a test

    @wxtim
    wxtim committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    578094d View commit details
    Browse the repository at this point in the history

  6. put all sections in []

    @wxtim
    wxtim committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    4f79272 View commit details
    Browse the repository at this point in the history

  7. added testing for prettify config function

    @wxtim
    wxtim committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    b294624 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. fix bug @ronnie had 

    added test for subdirectories of log not being found
    @wxtim
    wxtim committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    fc2ee9f View commit details
    Browse the repository at this point in the history

  2. Added manual upgrade checks for items with complex upgraders.

    @wxtim
    wxtim committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    d36ca92 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2022

  1. Update cylc/flow/scripts/lint.py 

    Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
    @wxtim @MetRonnie
    wxtim and MetRonnie authored Jul 21, 2022
    Configuration menu
    Copy the full SHA
    c0df60c View commit details
    Browse the repository at this point in the history

  2. Update cylc/flow/scripts/lint.py 

    Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
    @wxtim @MetRonnie
    wxtim and MetRonnie authored Jul 21, 2022
    Configuration menu
    Copy the full SHA
    4a19b09 View commit details
    Browse the repository at this point in the history

  3. Update cylc/flow/scripts/lint.py 

    Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
    @wxtim @MetRonnie
    wxtim and MetRonnie authored Jul 21, 2022
    Configuration menu
    Copy the full SHA
    bacada2 View commit details
    Browse the repository at this point in the history

  4. Update cylc/flow/scripts/lint.py 

    Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
    @wxtim @MetRonnie
    wxtim and MetRonnie authored Jul 21, 2022
    Configuration menu
    Copy the full SHA
    85f83c5 View commit details
    Browse the repository at this point in the history

  5. Update cylc/flow/scripts/lint.py 

    Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
    @wxtim @MetRonnie
    wxtim and MetRonnie authored Jul 21, 2022
    Configuration menu
    Copy the full SHA
    1226f56 View commit details
    Browse the repository at this point in the history

  6. Update cylc/flow/scripts/lint.py 

    Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
    @wxtim @MetRonnie
    wxtim and MetRonnie authored Jul 21, 2022
    Configuration menu
    Copy the full SHA
    134d752 View commit details
    Browse the repository at this point in the history

  7. Update cylc/flow/scripts/lint.py 

    Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
    @wxtim @MetRonnie
    wxtim and MetRonnie authored Jul 21, 2022
    Configuration menu
    Copy the full SHA
    d0f13df View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into cylc-linter

    @wxtim
    wxtim authored Jul 21, 2022
    Configuration menu
    Copy the full SHA
    165f6e2 View commit details
    Browse the repository at this point in the history

  9. Make the linter default behaviour be linting 

    Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
    @wxtim @MetRonnie
    wxtim and MetRonnie committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    350a287 View commit details
    Browse the repository at this point in the history

  10. fix regex

    @wxtim
    wxtim committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    01e39aa View commit details
    Browse the repository at this point in the history

  11. fix flake8 bug which crept into master

    @wxtim
    wxtim committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    d440b61 View commit details
    Browse the repository at this point in the history

  12. updated functional test

    @wxtim
    wxtim committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    5b9b381 View commit details
    Browse the repository at this point in the history

  13. fixed broken line

    @wxtim
    wxtim committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    ebb8d6c View commit details
    Browse the repository at this point in the history

  14. merge

    @wxtim
    wxtim committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    cbb459b View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2022

  1. Merge branch 'master' into cylc-linter

    @wxtim
    wxtim authored Jul 22, 2022
    Configuration menu
    Copy the full SHA
    8562293 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2022

  1. cylc lint: review feedback

    @oliver-sanders
    oliver-sanders committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    a3964f0 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #44 from oliver-sanders/cylc-lint 

    cylc lint: review feedback
    @wxtim
    wxtim authored Jul 25, 2022
    Configuration menu
    Copy the full SHA
    b1596b1 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2022

  1. Apply suggestions from code review 

    - Delete the examples section of the docstring as per HO suggestion

Co-authored-by: Hilary James Oliver <hilary.j.oliver@gmail.com>
    @wxtim @hjoliver
    wxtim and hjoliver authored Jul 26, 2022
    Configuration menu
    Copy the full SHA
    8b8a9e8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into cylc-linter

    @wxtim
    wxtim authored Jul 26, 2022
    Configuration menu
    Copy the full SHA
    44cc3e6 View commit details
    Browse the repository at this point in the history

  3. fix bug

    @wxtim
    wxtim committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    9ee971d View commit details
    Browse the repository at this point in the history

  4. fix problems @osanders found on review

    @wxtim
    wxtim committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    ffa7138 View commit details
    Browse the repository at this point in the history

  5. fix unit tests

    @wxtim
    wxtim committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    31d6799 View commit details
    Browse the repository at this point in the history

  6. fixed functional tests

    @wxtim
    wxtim committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    bef898d View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. SPAG

    @wxtim
    wxtim committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    3692ca7 View commit details
    Browse the repository at this point in the history

  2. made __doc__ rst to make autodoc work nicely.

    @wxtim
    wxtim committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    f403bcf View commit details
    Browse the repository at this point in the history

  3. fix test

    @wxtim
    wxtim committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    f9a2c56 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review

    @wxtim
    wxtim authored Jul 27, 2022
    Configuration menu
    Copy the full SHA
    fea7250 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review

    @wxtim
    wxtim authored Jul 27, 2022
    Configuration menu
    Copy the full SHA
    7722995 View commit details
    Browse the repository at this point in the history

  6. fixed review bug -

    @wxtim
    wxtim committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    ff83770 View commit details
    Browse the repository at this point in the history

  7. fix

    @wxtim
    wxtim committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    8229168 View commit details
    Browse the repository at this point in the history

  8. Update cylc/flow/scripts/lint.py 

    Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
    @wxtim @MetRonnie
    wxtim and MetRonnie authored Jul 27, 2022
    Configuration menu
    Copy the full SHA
    f079b35 View commit details
    Browse the repository at this point in the history

  9. nice plural

    @wxtim
    wxtim committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    1005f08 View commit details
    Browse the repository at this point in the history