-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't abort if cleaning multiple workflows. #4949
Conversation
Not at all, but happy to wait for 8.x for this. |
But it's a trivial change, done already, and fixes a bug - so let's get it in! [I want to nail as many easy-to-fix user-facing bugs as possible before 8.0] |
init_clean(workflow, opts) | ||
try: | ||
init_clean(workflow, opts) | ||
except Exception as exc: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Probably one of the few situations where it's fine to catch all exceptions IMO - but can try to be specific if needed.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine here, sometimes you need to catch anything.
Looks fine, tried out manually, test failed CI and needs some bodging. |
CI fixed - the new test should have had a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked out, tests run. No problems spotted. Thanks @hjoliver.
These changes close #4934
@oliver-sanders - any problem with nailing this now?
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
andconda-environment.yml
.