Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add owner@host for SUCCEEDED and FAILED tasks #5016

Merged
merged 2 commits into from
Aug 12, 2022

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Jul 26, 2022

These changes close #4516

Fix bug where failed tasks could be polled back to incorrect states on restart.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Manual test instructions added to the ticket. It's horrid./
  • Appropriate change log entry included.
  • No documentation update required.

@wxtim wxtim self-assigned this Jul 26, 2022
@wxtim wxtim requested a review from dpmatthews July 26, 2022 12:57
@dpmatthews
Copy link
Contributor

Works fine in my test

@wxtim wxtim linked an issue Jul 27, 2022 that may be closed by this pull request
@wxtim wxtim added bug Something is wrong :( small labels Jul 27, 2022
@wxtim wxtim added this to the cylc-7.8.x milestone Jul 27, 2022
@wxtim
Copy link
Member Author

wxtim commented Jul 29, 2022

I've spent quite a long time trying to test this and am finding it tricky. Can we manually test it, pending me raising other questions about testing Cylc 7?

To test manually at the Met Office use ${TIMSHOME}/cylc-run/bug.polling-restart.

You can either turn this into a new workflow and replicate the whole bug or git clone it (it's a git repo) and do a cylc restart without my change (should show the bug), git reset HEAD --hard and try a cylc restart with the change.

Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I haven't been able to reproduce the issue because I don't think I'm set up for the hosts you gave in your example

Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Merging, as @dpmatthews has also tested and confirmed the fix.

@MetRonnie MetRonnie merged commit 938995f into cylc:7.8.x Aug 12, 2022
@wxtim wxtim deleted the polling_bugfix branch August 12, 2022 14:39
@hjoliver hjoliver modified the milestones: cylc-7.8.x, 7.8.12 Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :( small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

job polling broken for failed jobs after restart
4 participants