reload: preserve retry xtriggers on reload #5040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-sanders
changed the title
* Closes cylc#4866 * Reload causes new instances of each task to be created. * The attributes of the old instances are copied onto the new ones. * Xtriggers were not copied so were lost. * This means that all xtriggers were effectively deleted on reload.
MetRonnie
changed the title
MetRonnie
approved these changes
Aug 3, 2022
Comment on lines
+37
to
+39
| # should be long enough for the reload to complete | ||
| # (annoyingly we can't make this event driven) | ||
| execution retry delays = PT1M |
There was a problem hiding this comment.
Would it be worth moving this test into tests/flakyfunctional and possibly cutting down this delay, in order that it doesn't hog time in the tests/functional runs on GH Actions?
There was a problem hiding this comment.
No evidence that it's flaky, yet, so no need to bump it in there.
(FYI: flakyfunction is kinda pointless, not all flakyfunctional tests are flaky and not all functional tests aren't, would like to get rid of this one day...).
There was a problem hiding this comment.
I know, just conscious of the fact we are approaching the timeout limit on GH Actions. May have to either increase the limit or add an extra chunk soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfgandconda-environment.yml.