Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reversed data-store edge source-target #5149

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

dwsutherland
Copy link
Member

@dwsutherland dwsutherland commented Sep 21, 2022

closes #5099

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • If this is a bug fix, PRs raised to both master and the relevant maintenance branch (bug fix, but not used yet).

@dwsutherland dwsutherland added the bug Something is wrong :( label Sep 21, 2022
@dwsutherland dwsutherland self-assigned this Sep 21, 2022
@oliver-sanders oliver-sanders added this to the cylc-8.0.3 milestone Sep 21, 2022
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brill, cheers, fix makes sense.

Tested with the workflow in the issue, couldn't see any reversed edges in the first few cycles.

LGTM.

@oliver-sanders oliver-sanders merged commit ce00060 into cylc:master Sep 21, 2022
@oliver-sanders oliver-sanders modified the milestones: cylc-8.0.3, cylc-8.1.0 Sep 22, 2022
@oliver-sanders oliver-sanders mentioned this pull request Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NodesEdges: source and target reversed
2 participants